New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance improvements #5

Merged

Luzifix merged 2 commits into ModernWoWTools:master from Marlamin:master

Jul 9, 2024

Contributor

Marlamin commented Jul 9, 2024

Adds a cache for reflection as I believe these results don't change during runtime (about 50-60% of CPU time was spent here during ADT reading)
Bail out of chunk seeking if we read outside of the buffer or finish reading the buffer (it was throwing caught EndOfStreamExceptions)
Fix typo

Should be non-breaking changes, but obviously give it a test anyways.

Marlamin added 2 commits

July 9, 2024 14:17


          Add cache for extension reflecting

a5903f9


          Fix typo & EndOfStream exceptions

7695ed9

Luzifix merged commit e6b2c8b into ModernWoWTools:master

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet